Skip to content

Products tab: Check horizontal size class before selecting first product #16158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2025
Merged

Products tab: Check horizontal size class before selecting first product #16158

merged 1 commit into from
Sep 23, 2025

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Sep 22, 2025 •
edited
Loading

Closes WOOMOB-1365

Description

When built with Xcode 26, for some reason the splitViewController.isCollapsed is not sufficient to determine when the app is run on iPhones, so this PR adds an additional check for size class before auto-selecting the first product upon initial load of the product list.

Testing steps

  • Build the app with Xcode 26 to an iPhone simulator.
  • Navigate to the Products tab and confirm that the product list is displayed.
  • Optional: Build the app to an iPad and confirm that the product list is displayed when the app is in side-by-side mode, and auto select works in full size mode.

Testing information

  • Tested with simulator iPhone 17 and iPad mini.
  • Also tested alpha build.

Screenshots

Before:

simulator_screen_recording_-_iphone_17_-_2025-09-18_at_12.12.18.mp4

After:

Simulator.Screen.Recording.-.iPhone.17.-.2025-09-22.at.09.55.39.mov
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 23.4 milestone Sep 22, 2025
@itsmeichigo itsmeichigo added type: bug A confirmed bug. feature: product list Related to the product list. feature: split view Tasks related to iPad SplitView Mode labels Sep 22, 2025
@itsmeichigo itsmeichigo marked this pull request as ready for review September 22, 2025 02:56
@itsmeichigo itsmeichigo requested a review from jaclync September 22, 2025 02:57
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 22, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16158-db6dfd3
Version23.3
Bundle IDcom.automattic.alpha.woocommerce
Commitdb6dfd3
Installation URL33488us6t5f4g
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

jaclync
jaclync approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix :shipit: it seems like isCollapsed could be not accurate when the trait collection is still unspecified from this SO post. Interestingly, I wasn't able to reproduce this in trunk in simulators - iPhone SE (3rd gen) iOS 17.4, iPhone 16e iOS 18.5, built from Xcode 26. But they continue to work with the PR changes.

RafaelKayumov
RafaelKayumov approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@RafaelKayumov RafaelKayumov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the fix

@itsmeichigo
Copy link
Contributor Author

itsmeichigo commented Sep 23, 2025

Interestingly, I wasn't able to reproduce this in trunk in simulators - iPhone SE (3rd gen) iOS 17.4, iPhone 16e iOS 18.5, built from Xcode 26

@jaclync I was able to reproduce this with simulators running iOS 26 only. Maybe this is specific to iOS 26 only?

I'll merge this PR for now, thanks everyone for the reviews!

@itsmeichigo itsmeichigo merged commit a7f8e59 into trunk Sep 23, 2025
28 checks passed
@itsmeichigo itsmeichigo deleted the woomob-1365-ios-26-product-tab branch September 23, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelKayumov RafaelKayumov RafaelKayumov approved these changes

@jaclync jaclync jaclync approved these changes

Assignees

No one assigned

Labels

feature: product list Related to the product list. feature: split view Tasks related to iPad SplitView Mode type: bug A confirmed bug.

Projects

None yet

Milestone

23.4

Development

Successfully merging this pull request may close these issues.

5 participants

@itsmeichigo @wpmobilebot @RafaelKayumov @jaclync